Do not include Facebook license on users codegen'd code #32840
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D33455176 |
Base commit: ca5aaa7 |
Base commit: ca5aaa7 |
Summary: Pull Request resolved: facebook#32840 Closes facebook#31516 I've cherry-picked the original PR that had merge conficts + updated all the headers as the one for the TurboModule generators were not handled. Original Commit Message from acoates The codegen generates a Facebook copyright notice at the top of the generated files. While this might make sense on the core files, this codegen will be run on external components too. The notice also refers to a LICENSE file in the root of this project, which might not be there if this is run on another project. I did a quick look at some of the codegen that we ship within windows dev tools, and it looks like we normally just have comments saying the file was codegen'd and so the file shouldn't be manually edited. Open to suggestions on what the comment header should say. Changelog: [General] [Changed] - Do not include Facebook license on users codegen'd code Differential Revision: D33455176 fbshipit-source-id: 5bcc73155d79ee7128726ec040bb6a5f94623baf
|
This pull request was exported from Phabricator. Differential Revision: D33455176 |
cortinico
force-pushed
the
export-D33455176
branch
from
cf68f9e
to
662dc1e
Compare
|
This pull request was successfully merged by @cortinico in 4509679. When will my fix make it into a release? | Upcoming Releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Closes #31516
I've cherry-picked the original PR that had merge conficts + updated all
the headers as the one for the TurboModule generators were not handled.
Original Commit Message from acoates
The codegen generates a Facebook copyright notice at the top of the generated files.
While this might make sense on the core files, this codegen will be run on external components too.
The notice also refers to a LICENSE file in the root of this project, which might not be there if this is run on another project.
I did a quick look at some of the codegen that we ship within windows dev tools, and it looks like we normally just have comments
saying the file was codegen'd and so the file shouldn't be manually edited.
Open to suggestions on what the comment header should say.
Changelog:
[General] [Changed] - Do not include Facebook license on users codegen'd code
Differential Revision: D33455176